Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Changes to Navbar across all pages #909

Merged
merged 24 commits into from
Oct 18, 2024
Merged

fix: Changes to Navbar across all pages #909

merged 24 commits into from
Oct 18, 2024

Conversation

KhawajaFashi
Copy link
Contributor

Description

fixes #791

I have made changes to:

  • Changed the navbar across all pages
  • Added navbar and dark mode in the nearby.html page
  • Added chatbot and translator in the nearby.html page and other pages on which it was missing
  • Some important UI changes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the contributing document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added necessary tests to ensure my changes are effective.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

KhawajaFashi and others added 19 commits October 14, 2024 12:14
@KhawajaFashi
Merge branch 'mansiruhil13:main' into main
0e2d29b
Ui change
608b067
Merge branch 'main' of https://github.com/KhawajaFashi/Bobble-AI
2d7f05f
Merge remote-tracking branch 'upstream/main'
9a34447
UI
4a552dc
index.html
2f64801
OAuth Authentication
f650dd8
Merge branch 'home_ui' of https://github.com/KhawajaFashi/Bobble-AI i…
f22b99a 
…nto home_ui
Merge remote-tracking branch 'upstream/main'
777cc55
Merge branch 'home_ui' of https://github.com/KhawajaFashi/Bobble-AI
d6bb4ac
ui
881646b
Navbar UI Changes Dark Mode addition and other UI changes
dbf0c62
@KhawajaFashi
Merge branch 'main' into main
2f7b7cc
Nav changes
691058c
@KhawajaFashi
Merge branch 'main' into main
dbda257
@KhawajaFashi
Merge branch 'main' into main
7660c33
Merge branch 'main' of https://github.com/KhawajaFashi/Bobble-AI
3c5b185
Merge branch 'main' of https://github.com/KhawajaFashi/Bobble-AI
4c9f648
nearby.html
be24b3b
@vercel Vercel
Copy link

vercel bot commented Oct 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bobble-ai-rcmb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 10:40pm

@github-actions GitHub Actions
Copy link

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@KhawajaFashi
Copy link
Contributor Author

@mansiruhil13 mam review this pull request I had issues with the branch changes so I had to open another pull request now everything is fine and there are no conflicts, so plz assign the previous labels to this pr and its ready to merge and another thing in up.html all the functionalities are gone in the original website so I synced my up.html with the original.

@KhawajaFashi
Copy link
Contributor Author

I have synced the recent changes done in the upstream and there are no conflicts you can merge it now

@KhawajaFashi
Copy link
Contributor Author

KhawajaFashi commented Oct 17, 2024 •
edited
Loading

And mam you closed issue #791 without merging this pr and I have a pending issue waiting for you to assign it to me #854.

@KhawajaFashi KhawajaFashi changed the title Changes to Navbar across all pages fix. Changes to Navbar across all pages Oct 18, 2024
@KhawajaFashi KhawajaFashi changed the title fix. Changes to Navbar across all pages fix: Changes to Navbar across all pages Oct 18, 2024
@mansiruhil13 mansiruhil13 merged commit 82e3f55 into mansiruhil13:main Oct 18, 2024
2 checks passed
@github-actions GitHub Actions
Copy link

🚀 Thank you for your contribution! This pull request has been closed. If you have any questions or need further assistance, feel free to reach out.

@KhawajaFashi
Copy link
Contributor Author

KhawajaFashi commented Oct 18, 2024 •
edited
Loading

@mansiruhil13 plz add level 3 label like you added in the previous pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansiruhil13 mansiruhil13 Awaiting requested review from mansiruhil13

Assignees

@KhawajaFashi KhawajaFashi

Labels
gssoc-ext hacktoberfest hacktoberfest-accepted level2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: I want to improve the navbar like on index.html and make it available to all other pages
2 participants
@KhawajaFashi @mansiruhil13